yiguolei commented on code in PR #64413:
URL: https://github.com/apache/doris/pull/64413#discussion_r3450410832
##########
be/src/storage/segment/segment_iterator.cpp:
##########
@@ -3165,32 +3048,10 @@ Status SegmentIterator::_process_eof(Block* block) {
Status SegmentIterator::_process_common_expr(uint16_t* sel_rowid_idx,
uint16_t& selected_size,
Block* block) {
- // Here we just use col0 as row_number indicator. when reach here, we will
calculate the predicates first.
- // then use the result to reduce our data read(that is, expr push down).
there's now row in block means the first
- // column is not in common expr. so it's safe to replace it temporarily
to provide correct `selected_size`.
VLOG_DEBUG << fmt::format("Execute common expr. block rows {}, selected
size {}", block->rows(),
_selected_size);
- bool need_mock_col = block->rows() != selected_size;
- MutableColumnPtr col0;
- if (need_mock_col) {
- col0 = std::move(*block->get_by_position(0).column).mutate();
- block->replace_by_position(
- 0,
block->get_by_position(0).type->create_column_const_with_default_value(
- _selected_size));
- }
-
- std::vector<VExprContext*> common_ctxs;
- common_ctxs.reserve(_common_expr_ctxs_push_down.size());
- for (auto& ctx : _common_expr_ctxs_push_down) {
- common_ctxs.push_back(ctx.get());
- }
- _output_index_result_column(common_ctxs, _sel_rowid_idx.data(),
_selected_size, block);
Review Comment:
为什么不需要 _output_index_result_column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
