mrhhsg commented on code in PR #63389: URL: https://github.com/apache/doris/pull/63389#discussion_r3456564296
########## be/src/storage/index/zone_map/zonemap_eval_context.cpp: ########## @@ -0,0 +1,71 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include "storage/index/zone_map/zonemap_eval_context.h" + +#include <algorithm> +#include <string> + +#include "runtime/runtime_profile.h" + +namespace doris { + +const segment_v2::ZoneMap* ZoneMapEvalContext::zone_map(int slot_index) const { Review Comment: 因为可能会有大量的 page zonemap， 如果放在 shared_ptr 里面会有大量的堆内存申请&释放，对性能应该还是有一定影响的 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
