yiguolei commented on code in PR #63389:
URL: https://github.com/apache/doris/pull/63389#discussion_r3457994035
##########
be/src/exprs/vdirect_in_predicate.h:
##########
@@ -30,8 +37,12 @@ class VDirectInPredicate final : public VExpr {
ENABLE_FACTORY_CREATOR(VDirectInPredicate);
public:
- VDirectInPredicate(const TExprNode& node, const
std::shared_ptr<HybridSetBase>& filter)
- : VExpr(node), _filter(filter), _expr_name("direct_in_predicate")
{}
+ VDirectInPredicate(const TExprNode& node, const
std::shared_ptr<HybridSetBase>& filter,
+ bool hybrid_set_values_match_child_type = true)
+ : VExpr(node),
Review Comment:
别加各种默认值了
再就是莫名奇妙加了一个参数也不知道是做啥用的，注释都没有
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
