morrySnow commented on code in PR #64618:
URL: https://github.com/apache/doris/pull/64618#discussion_r3457572973
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/jobs/executor/Rewriter.java:
##########
@@ -606,7 +606,7 @@ public class Rewriter extends AbstractBatchJobExecutor {
topic("",
cascadesContext ->
cascadesContext.rewritePlanContainsTypes(SetOperation.class),
topDown(new MergeOneRowRelationIntoUnion()),
- costBased(topDown(new
InferSetOperatorDistinct())),
+ topDown(new InferSetOperatorDistinct()),
Review Comment:
**Silent loss of hint support**: Changing from `costBased(topDown(...))` to
`topDown(...)` means `use_INFER_SET_OPERATOR_DISTINCT` and
`use_NO_INFER_SET_OPERATOR_DISTINCT` hints are now silently ignored.
Previously, `CostBasedRewriteJob.checkRuleHint()` enforced these hints.
If this is intentional, please:
1. Add a `TODO` comment here noting the hints are deprecated and should be
removed from the hint registry
2. Document the deprecation in the PR description
3. Consider logging a warning when these hints are encountered, so users
know their hints have no effect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
