Mryange opened a new pull request, #64829:
URL: https://github.com/apache/doris/pull/64829
### What problem does this PR solve?
Reading Arrow FIXED_SIZE_BINARY arrays into Doris string columns used mixed
index bases when `read_column_from_arrow` was called with a non-zero `start`.
The data pointer was advanced to `start`, but null checks still used indexes
beginning at 0. As a result, nullable sliced reads could apply the wrong null
bitmap entries and insert default values for non-null rows.
Root cause: the FIXED_SIZE_BINARY branch used relative offsets for data
access while calling `IsNull()` with the same relative offset. This change
reads each row with the absolute Arrow index for both `IsNull(offset_i)` and
`GetValue(offset_i)`.
A unit test covers a nullable FIXED_SIZE_BINARY array read from `[1, 4)`,
which failed before the fix and now reads the expected values.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
