hoshinojyunn commented on code in PR #64652:
URL: https://github.com/apache/doris/pull/64652#discussion_r3496712113
##########
fe/fe-core/src/main/java/org/apache/doris/task/CreateReplicaTask.java:
##########
@@ -319,11 +320,14 @@ public TCreateTabletReq toThrift() {
tColumns = (List<TColumn>) tCols;
} else {
tColumns = new ArrayList<>();
+ Set<String> namedBfColumns =
Index.extractBloomFilterColumns(indexes);
Review Comment:
Thanks. I agree there is a real mismatch here, but I am treating it as an
existing semantic boundary rather than something this PR should partially fix.
Current behavior is:
- non-base materialized indexes (for example rollup/MV shadow replicas, and
the corresponding create-table / add-partition non-base paths) still do not
receive named secondary-index metadata in replica/create-tablet tasks;
- legacy BF columns are still propagated through `bfColumns` from table
properties;
- FE display/meta now shows the effective BF columns from both legacy table
properties and named `BLOOMFILTER` indexes.
So today named BF on non-base indexes is indeed not fully aligned between
physical materialization and FE display. I do not want to "fix" this in this PR
by only passing named BF indexes into rollup schema-change replica tasks,
because that would make rollup behavior differ before vs after schema change
and would deepen the split between the legacy `bloom_filter_columns` path and
the named-index path.
The planned direction is to refactor bloom filter metadata as a whole,
gradually deprecate/remove the legacy table-property mechanism for BF columns,
and then move BF fully onto named `BLOOMFILTER` indexes. Once that migration is
ready, non-base materialization and display semantics can be unified cleanly.
So for this PR I am keeping the scope to:
- named `BLOOMFILTER` DDL support
- index-level `bloom_filter_fpp`
- FE/BE materialization for the currently supported paths
- compatibility with legacy `bloom_filter_columns`
- FE/BE UT and regression coverage in that scope
I will note this limitation explicitly in the PR description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
