hoshinojyunn commented on code in PR #64652:
URL: https://github.com/apache/doris/pull/64652#discussion_r3505489755
##########
fe/fe-core/src/main/java/org/apache/doris/task/CreateReplicaTask.java:
##########
@@ -374,8 +378,10 @@ public TCreateTabletReq toThrift() {
tSchema.setIndexes(tIndexes);
}
- if (bfColumns != null) {
- tSchema.setBloomFilterFpp(bfFpp);
+ boolean hasAnyBf = (bfColumns != null && !bfColumns.isEmpty())
+ || !Index.extractBloomFilterColumns(indexes).isEmpty();
+ if (hasAnyBf) {
+ tSchema.setBloomFilterFpp(bfFpp == 0 ?
FeConstants.default_bloom_filter_fpp : bfFpp);
Review Comment:
To ensure consistency in replica creation semantics between cloud and
non-cloud environments—given that the FPP in table properties should depend
solely on the Bloom filter (BF) columns defined in those properties—the FPP
setting logic in `CloudInternalCatalog` has been modified as follows:
```java
// Set bfFpp only when BF columns are defined in the table properties
if (bfColumns != null) {
schemaBuilder.setBfFpp(bfFpp);
}
```
Previously, `bfFpp` was set regardless of whether `bfColumns` was null,
which was semantically incorrect; the change aligns the behavior between cloud
and non-cloud implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
