nishant94 commented on code in PR #64667:
URL: https://github.com/apache/doris/pull/64667#discussion_r3504706489
##########
be/CMakeLists.txt:
##########
@@ -318,6 +318,12 @@ install(DIRECTORY
${BASE_DIR}/dict/pinyin
DESTINATION ${OUTPUT_DIR}/dict)
+# Japanese kuromoji dictionary
+install(DIRECTORY
+ ${BASE_DIR}/dict/kuromoji
+ DESTINATION ${OUTPUT_DIR}/dict
+ OPTIONAL)
Review Comment:
Agreed, shipping a package that only contains the `README` would be a trap.
I made two changes to handle this:
- `kuromoji_dict` now builds as part of ALL, so a normal build generates
`system.bin/matrix.bin/chardef.bin/unkdict.bin` from the staged mecab-ipadic.
- Dropped `OPTIONAL` and added an install-time check that `FATAL_ERRORs` if
any of the four files are missing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
