nishant94 commented on code in PR #64667:
URL: https://github.com/apache/doris/pull/64667#discussion_r3504726257
##########
be/src/storage/index/inverted/inverted_index_parser.cpp:
##########
@@ -89,8 +93,13 @@ std::string get_parser_mode_string_from_properties(
if (parser_it == properties.end()) {
parser_it = properties.find(INVERTED_INDEX_PARSER_KEY_ALIAS);
}
- if (parser_it != properties.end() && parser_it->second ==
INVERTED_INDEX_PARSER_IK) {
- return INVERTED_INDEX_PARSER_SMART;
+ if (parser_it != properties.end()) {
+ if (parser_it->second == INVERTED_INDEX_PARSER_IK) {
+ return INVERTED_INDEX_PARSER_SMART;
+ }
+ if (parser_it->second == INVERTED_INDEX_PARSER_KUROMOJI) {
+ return INVERTED_INDEX_PARSER_KUROMOJI_SEARCH;
Review Comment:
Good catch !!
##########
be/src/storage/index/inverted/inverted_index_parser.cpp:
##########
@@ -89,8 +93,13 @@ std::string get_parser_mode_string_from_properties(
if (parser_it == properties.end()) {
parser_it = properties.find(INVERTED_INDEX_PARSER_KEY_ALIAS);
}
- if (parser_it != properties.end() && parser_it->second ==
INVERTED_INDEX_PARSER_IK) {
- return INVERTED_INDEX_PARSER_SMART;
+ if (parser_it != properties.end()) {
+ if (parser_it->second == INVERTED_INDEX_PARSER_IK) {
+ return INVERTED_INDEX_PARSER_SMART;
+ }
+ if (parser_it->second == INVERTED_INDEX_PARSER_KUROMOJI) {
+ return INVERTED_INDEX_PARSER_KUROMOJI_SEARCH;
Review Comment:
Updated, `InvertedIndexProperties.getInvertedIndexParserMode()` to return
search for kuromoji so it matches the BE default, and added FE tests for the
kuromoji default (and explicit) mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
