gavinchou commented on PR #65053: URL: https://github.com/apache/doris/pull/65053#issuecomment-4858637571
Addressed the requested changes: - Reused `checkStoragePolicyExist(newStoragePolicy)` before the partition storage-policy resource precheck, so uninitialized `default_storage_policy` is rejected before any BE tablet meta update can be sent. - Added `ModifyPartitionStoragePolicyTest` with a spy `SchemaChangeHandler` to verify rejected `MODIFY PARTITION` paths do not call `updatePartitionsProperties()`. Local check: `git diff --check` passed. Targeted FE UT could not run in this local environment because `run-fe-ut.sh` stops in `env.sh` with missing Homebrew. /review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
