github-actions[bot] commented on code in PR #65053:
URL: https://github.com/apache/doris/pull/65053#discussion_r3508122060
##########
fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java:
##########
@@ -916,6 +920,57 @@ private void processRename(Database db, Table table,
List<AlterOp> alterOps) thr
}
}
+ private void checkModifyPartitionStoragePolicyResource(OlapTable
olapTable, List<String> partitionNames,
+ Map<String, String> properties, boolean isTempPartition) throws
DdlException, AnalysisException {
+ if (!PropertyAnalyzer.hasStoragePolicy(properties)) {
+ return;
+ }
+
+ String newStoragePolicy =
PropertyAnalyzer.analyzeStoragePolicy(properties);
Review Comment:
Returning here still leaves the cancellation path unguarded. For `ALTER
TABLE ... MODIFY PARTITION ... SET ("storage_policy"="")`,
`updatePartitionsProperties()` runs before `modifyPartitionsProperty()`, and
`storagePolicyNameToId("")` maps the policy to `0`, so FE can send
`UpdateTabletMetaInfoTask` reset tasks to BE. Only after that does the
empty-policy branch reject cancellation when the partition already has remote
data or is due to cool down within 20 seconds. Please move/reuse that
cancellation validation before the BE update call as well, and add the same
spy-style unit coverage for the rejected empty-policy case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
