github-actions[bot] commented on code in PR #65620:
URL: https://github.com/apache/doris/pull/65620#discussion_r3585371659
##########
regression-test/suites/fault_injection_p0/partial_update/test_partial_update_skip_compaction.groovy:
##########
@@ -166,8 +177,19 @@ suite("test_partial_update_skip_compaction",
"nonConcurrent") {
// let the partial update load publish
disable_block_in_publish()
+ disable_publish_spin_wait()
t1.join()
+ Awaitility.await().atMost(30, TimeUnit.SECONDS).pollInterval(100,
TimeUnit.MILLISECONDS).until(
Review Comment:
This wait only proves the partial update becomes visible after the debug
points are disabled. It still does not prove the insert had actually reached
`EnginePublishVersionTask::execute.enable_spin_wait` before full compaction
started, because the pre-compaction synchronization is still just
`Thread.sleep(500)`. If the insert is slow to reach publish, compaction can
finish first; then disabling the debug points lets the insert publish normally
and this Awaitility block still passes, so the test has not exercised the
blocked-publish/compaction overlap it is meant to cover. Please replace the
fixed sleep with a deterministic handshake that fails unless the targeted
publish wait has been hit before starting compaction, such as an observable
debug-point hit signal or another publish/transaction state that proves the
insert is blocked there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
