github-actions[bot] commented on code in PR #65620:
URL: https://github.com/apache/doris/pull/65620#discussion_r3585380856
##########
regression-test/suites/fault_injection_p0/partial_update/test_partial_update_skip_compaction.groovy:
##########
@@ -166,8 +177,19 @@ suite("test_partial_update_skip_compaction",
"nonConcurrent") {
// let the partial update load publish
disable_block_in_publish()
Review Comment:
This only proves that the partial update is eventually visible after the
block is released. In cloud mode `check_rs_metas` returns immediately, so if
`CloudGlobalTransactionMgr.getDeleteBitmapUpdateLock.enable_spin_wait` is
missed or reached after `be_run_full_compaction`, the load can commit before
compaction, compaction can still report success, and this count wait still
passes. Please add a cloud-visible pre-release assertion/latch that the load
has actually entered the spin wait before compaction proceeds, such as waiting
while the old values remain visible or exposing a debug-point hit signal, then
keep this final value check as the post-release verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
