hoshinojyunn commented on code in PR #64652:
URL: https://github.com/apache/doris/pull/64652#discussion_r3586625472
##########
fe/fe-core/src/main/java/org/apache/doris/task/CreateReplicaTask.java:
##########
@@ -319,11 +319,14 @@ public TCreateTabletReq toThrift() {
tColumns = (List<TColumn>) tCols;
} else {
tColumns = new ArrayList<>();
+ Set<String> namedBfColumns =
Index.extractBloomFilterColumns(indexes);
for (int i = 0; i < columns.size(); i++) {
Review Comment:
Currently, considering only the creation of replica tasks in the base/rollup
of the FE, the shared object pool does cause the tColumn state used by both to
be related to the replica task creation order. However, the BE has a fallback
mechanism:
* If the `base` is created first and the `tColumn` is marked with a bf flag,
the subsequent `tColumns` in the `rollup` will also have this flag.
* If the `rollup` is created first, the subsequent `tColumns` in the `base`
will indeed not have the bf flag, but in the BE, if the indexes contain a
`BLOOMFILTER` type and the column is the corresponding column, the bf flag will
still be set, preventing the flag from being lost.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
