hoshinojyunn commented on code in PR #64652:
URL: https://github.com/apache/doris/pull/64652#discussion_r3588339836
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -3294,6 +3314,13 @@ private boolean processAddIndex(CreateIndexOp
createIndexOp, OlapTable olapTable
// so here update column name in CreateIndexClause after checkColumn
for indexDef,
// there will use the column name in olapTable instead of the column
name in CreateIndexClause.
alterIndex.setColumns(indexDef.getColumnNames());
+ List<Index> conflictIndexes = new ArrayList<>(newIndexes);
+ conflictIndexes.add(alterIndex);
Review Comment:
This is a common issue for both index light ops and non-light ops. Whenever
a mixed alter operation carries an index op that supports light, it will follow
the light path, even if other ops are not light. BF indexes will need to
support light in the future, so this issue will not be addressed for now.
##########
fe/fe-core/src/main/java/org/apache/doris/alter/SchemaChangeHandler.java:
##########
@@ -3294,6 +3314,13 @@ private boolean processAddIndex(CreateIndexOp
createIndexOp, OlapTable olapTable
// so here update column name in CreateIndexClause after checkColumn
for indexDef,
// there will use the column name in olapTable instead of the column
name in CreateIndexClause.
alterIndex.setColumns(indexDef.getColumnNames());
+ List<Index> conflictIndexes = new ArrayList<>(newIndexes);
+ conflictIndexes.add(alterIndex);
Review Comment:
This is a common issue for both index light ops and non-light ops. Whenever
a mixed alter operation carries an index op that supports light, it will follow
the light path, even if other ops are not light. BF indexes will need to
support light in the future, this issue will not be addressed for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
