Copilot commented on code in PR #65688:
URL: https://github.com/apache/doris/pull/65688#discussion_r3593131826
##########
fe/fe-core/src/main/java/org/apache/doris/job/offset/jdbc/JdbcSourceOffsetProvider.java:
##########
@@ -375,7 +389,7 @@ private boolean compareOffset(Map<String, String>
offsetFirst, Map<String, Strin
}
Integer cmp = parseCdcResponseData(
result.getResponse(), new TypeReference<Integer>() {});
- return cmp != null && cmp > 0;
+ return cmp;
Review Comment:
compareOffset() now returns an Integer that is auto-unboxed to int. If the
BE returns a successful envelope with a null `data` field,
`parseCdcResponseData()` will return null and this will trigger a
NullPointerException at unboxing, which is then caught by
hasMoreDataToConsume() and treated as "no more data". Handle null explicitly
and fail with a JobException that includes the raw response for diagnosis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
