JNSimba commented on code in PR #65688:
URL: https://github.com/apache/doris/pull/65688#discussion_r3599950248
##########
fe/fe-core/src/main/java/org/apache/doris/job/offset/jdbc/JdbcSourceOffsetProvider.java:
##########
@@ -286,11 +294,13 @@ public void fetchRemoteMeta(Map<String, String>
properties) throws Exception {
}
Map<String, String> newEndOffset = parseCdcResponseData(
result.getResponse(), new TypeReference<Map<String,
String>>() {});
- // null→value also counts as a change: upstream may have advanced
while fetch was blocked.
- if (endBinlogOffset == null ||
!endBinlogOffset.equals(newEndOffset)) {
- hasMoreData = true;
+ synchronized (splitsLock) {
+ // null→value also counts as a change: upstream may have
advanced while fetch was blocked.
+ if (endBinlogOffset == null ||
!endBinlogOffset.equals(newEndOffset)) {
+ hasMoreData = true;
+ }
+ endBinlogOffset = newEndOffset;
Review Comment:
This interval will be very short; the next correction will take place after
500ms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
