gavinchou commented on code in PR #65810:
URL: https://github.com/apache/doris/pull/65810#discussion_r3630625484
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/MaterializedIndex.java:
##########
@@ -34,21 +34,33 @@
public class MaterializedIndex extends MetaObject implements
GsonPostProcessable {
public enum IndexState {
NORMAL,
+ ROW_BINLOG,
@Deprecated
ROLLUP,
@Deprecated
SCHEMA_CHANGE,
- SHADOW; // index in SHADOW state is visible to load process, but
invisible to query
+ SHADOW, // index in SHADOW state is visible to load process, but
invisible to query
+ SHADOW_ROW_BINLOG;
public boolean isVisible() {
- return this == IndexState.NORMAL;
+ return this == IndexState.NORMAL || this == IndexState.ROW_BINLOG;
+ }
+
+ public boolean isRowBinlog() {
+ return this == IndexState.ROW_BINLOG || this ==
IndexState.SHADOW_ROW_BINLOG;
+ }
+
+ public boolean isShadow() {
+ return this == IndexState.SHADOW || this ==
IndexState.SHADOW_ROW_BINLOG;
}
}
public enum IndexExtState {
ALL,
- VISIBLE, // index state in NORMAL
- SHADOW // index state in SHADOW
+ ALL_EXCEPT_ROW_BINLOG, // exclude row binlog
+ VISIBLE, // exclude row binlog
+ VISIBLE_WITH_ROW_BINLOG,
Review Comment:
is there any side effect we use only `VISIBLE` for binlog and base table?
the `IndexExtState` seems too complex plus the `IndexState`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
