deardeng commented on code in PR #65810:
URL: https://github.com/apache/doris/pull/65810#discussion_r3644028719
##########
be/src/cloud/cloud_tablet_mgr.cpp:
##########
@@ -428,13 +434,21 @@ Status CloudTabletMgr::get_topn_tablets_to_compact(
int n, CompactionType compaction_type, const
std::function<bool(CloudTablet*)>& filter_out,
std::vector<std::shared_ptr<CloudTablet>>* tablets, int64_t*
max_score) {
DCHECK(compaction_type == CompactionType::BASE_COMPACTION ||
- compaction_type == CompactionType::CUMULATIVE_COMPACTION);
+ compaction_type == CompactionType::CUMULATIVE_COMPACTION ||
+ compaction_type == CompactionType::CUMU_BINLOG_COMPACTION);
*max_score = 0;
int64_t max_score_tablet_id = 0;
// clang-format off
auto score = [compaction_type](CloudTablet* t) {
+ if (compaction_type == CompactionType::CUMU_BINLOG_COMPACTION &&
!t->is_row_binlog_tablet()) {
Review Comment:
why not ?
if (compaction_type == CompactionType::CUMU_BINLOG_COMPACTION) { return {0};}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
