cyriltovena commented on code in PR #65433:
URL: https://github.com/apache/doris/pull/65433#discussion_r3636578405
##########
be/src/util/s3_util.h:
##########
@@ -101,6 +101,7 @@ struct S3ClientConf {
hash_code ^= request_timeout_ms;
hash_code ^= connect_timeout_ms;
hash_code ^= use_virtual_addressing;
+ hash_code ^= need_override_endpoint;
Review Comment:
Thank you for the concrete collision example. Fixed in fb13eb4608:
S3ClientConf now uses order-sensitive hash combining and exact equality, the
factory cache is keyed by the complete configuration so collisions are
equality-checked, and ObjClientHolder reset compares complete configurations
rather than hashes. The new factory and reset tests use the opposite boolean
pairs and verify distinct clients and a live reset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
