cyriltovena commented on code in PR #65433:
URL: https://github.com/apache/doris/pull/65433#discussion_r3636578559
##########
cloud/src/meta-service/meta_service_resource.cpp:
##########
@@ -1146,6 +1207,38 @@ static int alter_s3_storage_vault_by_id(InstanceInfoPB&
instance, std::unique_pt
return -1;
}
+ if (is_gcp_workload_identity_cred_provider(obj_info)) {
+ if (obj_info.has_ak() || obj_info.has_role_arn()) {
+ code = MetaServiceCode::INVALID_ARGUMENT;
+ msg = "invalid argument, GCP workload identity can not be set
together with ak/sk or "
+ "role_arn";
+ LOG(WARNING) << msg;
+ return -1;
+ }
+ if (!new_vault.obj_info().has_provider() ||
Review Comment:
Thank you for tracing the partial-commit path. Fixed in dd74778e72:
ALTER_S3_VAULT now returns immediately when its helper fails, before the shared
transaction commit. The parallel HDFS alter path now follows the same error
contract. The negative rename-plus-Workload-Identity test verifies that both
the instance name mapping and stored vault remain unchanged after rejection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
