github-actions[bot] commented on code in PR #65847: URL: https://github.com/apache/doris/pull/65847#discussion_r3649345890
########## fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/agg/PercentileApproxArray.java: ########## @@ -0,0 +1,127 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.trees.expressions.functions.agg; + +import org.apache.doris.catalog.FunctionSignature; +import org.apache.doris.nereids.exceptions.AnalysisException; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.functions.ExplicitlyCastableSignature; +import org.apache.doris.nereids.trees.expressions.literal.ArrayLiteral; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.trees.expressions.literal.NullLiteral; +import org.apache.doris.nereids.trees.expressions.visitor.ExpressionVisitor; +import org.apache.doris.nereids.types.ArrayType; +import org.apache.doris.nereids.types.DoubleType; + +import com.google.common.base.Preconditions; +import com.google.common.collect.ImmutableList; + +import java.util.ArrayList; +import java.util.List; + +/** + * AggregateFunction 'percentile_approx_array'. + */ +public class PercentileApproxArray extends NotNullableAggregateFunction + implements ExplicitlyCastableSignature { + + public static final List<FunctionSignature> SIGNATURES = ImmutableList.of( + FunctionSignature.ret(ArrayType.of(DoubleType.INSTANCE)) + .args(DoubleType.INSTANCE, ArrayType.of(DoubleType.INSTANCE)), + FunctionSignature.ret(ArrayType.of(DoubleType.INSTANCE)) + .args(DoubleType.INSTANCE, ArrayType.of(DoubleType.INSTANCE), DoubleType.INSTANCE) + ); + + public PercentileApproxArray(Expression arg0, Expression arg1) { + this(false, arg0, arg1); + } + + public PercentileApproxArray(boolean distinct, Expression arg0, Expression arg1) { + super("percentile_approx_array", distinct, arg0, arg1); + } + + public PercentileApproxArray(Expression arg0, Expression arg1, Expression arg2) { + this(false, arg0, arg1, arg2); + } + + public PercentileApproxArray(boolean distinct, Expression arg0, Expression arg1, + Expression arg2) { + super("percentile_approx_array", distinct, arg0, arg1, arg2); + } + + /** constructor for withChildren and reuse signature */ + private PercentileApproxArray(AggregateFunctionParams functionParams) { + super(functionParams); + } + + @Override + public void checkLegalityBeforeTypeCoercion() { + if (!getArgument(1).isConstant()) { + throw new AnalysisException( + "percentile_approx_array requires second parameter must be a constant : " + this.toSql()); + } + if (arity() == 3 && !getArgument(2).isConstant()) { + throw new AnalysisException( + "percentile_approx_array requires the third parameter must be a constant : " + this.toSql()); + } + } + + @Override + public void checkLegalityAfterRewrite() { Review Comment: **[P2] Run range validation for the `_state` combinator.** `percentile_approx_array_state(CAST(NULL AS DOUBLE), [1.1])` never reaches this method: `StateCombinator` delegates only `checkLegalityBeforeTypeCoercion`, and its nested aggregate is not an expression child. On BE, the nullable wrapper skips the null row, so `PercentileApproxArrayState::init`/`check_quantile` also never runs and an uninitialized state is serialized successfully. This lets an invalid quantile produce a stored empty state even though the direct function rejects it. Please propagate the after-rewrite legality check to `_state` using its rewritten arguments, and cover this null-input case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
