eldenmoon commented on code in PR #65561: URL: https://github.com/apache/doris/pull/65561#discussion_r3654205766
########## be/src/core/value/variant/variant_batch_builder.h: ########## @@ -0,0 +1,323 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <array> +#include <cstddef> +#include <cstdint> +#include <memory> +#include <span> + +#include "core/pod_array.h" +#include "core/string_ref.h" +#include "core/value/variant/variant_metadata.h" +#include "core/value/variant/variant_value.h" + +namespace doris { + +// A validated, stack-only plan for one physical Variant scalar. The plan either owns a small +// inline textual fallback or borrows a StringRef until write() returns; it never allocates. +// Callers can therefore preflight a complete batch, reserve its final buffer once, and write +// directly into that buffer without constructing a temporary value tree per row. +class VariantScalarEncodingPlan { Review Comment: VariantScalarEncodingPlan 是否有过度设计， doris内部是否已有类似的逻辑，能否复用 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
