eldenmoon commented on code in PR #65561:
URL: https://github.com/apache/doris/pull/65561#discussion_r3654230375


##########
be/src/exprs/aggregate/aggregate_function_uniq.cpp:
##########
@@ -36,6 +36,11 @@ AggregateFunctionPtr create_aggregate_function_uniq(const 
std::string& name,
                                                     const DataTypePtr& 
result_type,
                                                     const bool 
result_is_nullable,
                                                     const 
AggregateFunctionAttr& attr) {
+    if (argument_types.size() == 1 &&
+        remove_nullable(argument_types[0])->get_primitive_type() == 
TYPE_VARIANT) {
+        return 
creator_without_type::create<AggregateFunctionUniqVariant>(argument_types,
+                                                                          
result_is_nullable, attr);

Review Comment:
   要特化 Field canonicalization、hash、相等、merge、序列化及 Arena 生命周期



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to