hubgeter commented on code in PR #65851:
URL: https://github.com/apache/doris/pull/65851#discussion_r3663575161
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/iceberg/source/IcebergScanNode.java:
##########
@@ -505,17 +521,55 @@ private List<String> getOrderedPathPartitionKeys() {
}
public void createScanRangeLocations() throws UserException {
- super.createScanRangeLocations();
+ Schema scanSchema = getQuerySchema();
+ Set<Integer> equalityDeleteFieldIds = Collections.emptySet();
+ if (!isSystemTable) {
+ equalityDeleteFieldIds = getEqualityDeleteFieldIdsForScan();
+ boolean requiresCurrentSemantics =
requiresRecursiveInitialDefaultMaterialization(
+ scanSchema, desc.getSlots()) ||
!equalityDeleteFieldIds.isEmpty();
+ if (!requiresCurrentSemantics
+ &&
hasSmoothUpgradeSourceBackend(backendPolicy.getBackends())) {
+ requiresCurrentSemantics =
requiresMissingRequiredFieldRejection(
Review Comment:
Fixed in 09f9bfec3e1. The required-field fence now starts with the selected
scan schema, then walks only the selected snapshot parent lineage with
schema-ID de-duplication. This includes schema-only targets while excluding
later main-line and off-lineage schemas. Added tests for both later/off-lineage
exclusion and a schema-only required-field target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
