hubgeter commented on code in PR #65851:
URL: https://github.com/apache/doris/pull/65851#discussion_r3663741471


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/BindSink.java:
##########
@@ -457,6 +467,13 @@ private static Map<String, NamedExpression> 
getColumnToOutput(
                     } else {
                         continue;
                     }
+                } else if (icebergWriteSchemaContext.isPresent()) {
+                    Expression defaultExpression = 
icebergWriteSchemaContext.get().resolveWriteDefault(column);

Review Comment:
   Fixed in 31227cc6e73. Static partition expressions are now seeded into the 
normal provided-column map before omitted-column default synthesis, so required 
identity partition fields do not call resolveWriteDefault(). This also 
preserves the existing cast, output ordering, and generated-column replacement 
path. Added testIcebergStaticPartitionSatisfiesRequiredFieldWithoutWriteDefault 
with a required v3 identity field and no write default. 
IcebergDDLAndDMLPlanTest passed 24/24, the expanded related FE set passed 
68/68, test_iceberg_static_partition_overwrite passed, and ./build.sh --fe -j16 
passed with zero Checkstyle violations.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to