eldenmoon opened a new pull request, #66204:
URL: https://github.com/apache/doris/pull/66204
### What problem does this PR solve?
Issue Number: None
Related PR: #65561
Problem Summary:
This PR reads legacy ColumnVariant segments directly into ColumnVariantV2
while preserving the existing V1 writer and reader paths.
It routes eligible non-insert scans through a scan-local V2 marker, reuses
the existing segment read plan, and assembles typed, sparse, document, and root
data with ownership transfer or borrowed views where possible. It also aligns
sparse no-match and legacy scalar behavior with V1, fixes two-phase RowID and
hierarchical multi-batch reads, keeps the shared BinaryColumnCache lower-bound
path, and adds reader/assembler coverage for malformed inputs and legacy DATE,
DATETIME, and DECIMALV2 cells.
NestedGroup, deprecated_enable_flatten_nested, and insert into v2 select v1
remain outside this change. The later local segment-iterator benchmark commit
is intentionally not included.
### Release note
None
### Check List (For Author)
- Test
- [x] Regression test
- [x] Unit Test
- [x] Manual test
- Post-rebase ASAN BE build passed with the default parallelism and
no -j.
- Post-rebase broad ASAN Variant BE UT is running; this PR remains
Draft until it completes.
- The focused V1-write/V2-scan regression passed on the patch before
the conflict-free rebase; range-diff confirmed the replayed patch was unchanged.
- Behavior changed:
- [x] Yes. With enable_variant_v2 enabled, eligible non-insert scans
read legacy Variant segments into ColumnVariantV2.
- Does this need documentation?
- [x] No.
### Scope notes
- V1 writer and V1 reader behavior remain available.
- V2 does not add NestedGroup or deprecated_enable_flatten_nested handling.
- insert into v2 select v1 is not supported by this PR.
- Typed columns are transferred/shared when possible; sparse binary cells
borrow source views and reuse the shared cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
