eldenmoon commented on code in PR #66204:
URL: https://github.com/apache/doris/pull/66204#discussion_r3671678640
##########
be/src/exec/scan/olap_scanner.cpp:
##########
@@ -699,14 +702,26 @@ Status OlapScanner::_init_variant_columns() {
if (slot->type()->get_primitive_type() == PrimitiveType::TYPE_VARIANT)
{
// Such columns are not exist in frontend schema info, so we need
to
// add them into tablet_schema for later column indexing.
- const auto& dt_variant =
- assert_cast<const
DataTypeVariant&>(*remove_nullable(slot->type()));
+ const auto* dt_variant =
Review Comment:
这段init_variant_columns代码感觉有点乱， 看下能不能整理一下加上代码注释
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
