eldenmoon commented on code in PR #66204: URL: https://github.com/apache/doris/pull/66204#discussion_r3671687765
########## be/src/storage/segment/variant/v2/variant_assembler_internal.h: ########## @@ -0,0 +1,115 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <cstddef> +#include <cstdint> +#include <memory> +#include <span> +#include <string_view> + +#include "core/column/column_array.h" +#include "core/column/column_map.h" +#include "core/column/column_string.h" +#include "core/custom_allocator.h" +#include "core/value/variant/variant_batch_builder.h" +#include "storage/segment/variant/v2/variant_assembler.h" +#include "storage/types.h" + +namespace doris::segment_v2::variant_v2::variant_assembler_internal { + +struct CompiledPath { + PathInData path; + DorisVector<StringRef> parts; + DataTypePtr type; + size_t source_index = 0; +}; + +struct RootJsonbView { + const ColumnString* values = nullptr; + const uint8_t* nulls = nullptr; + + bool is_null_at(size_t row) const noexcept { return nulls != nullptr && nulls[row] != 0; } + StringRef value_at(size_t row) const { return values->get_data_at(row); } +}; + +struct MapView { Review Comment: MapView是啥，干啥用的，名字很奇怪？？代码注释 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
