eldenmoon commented on code in PR #66204:
URL: https://github.com/apache/doris/pull/66204#discussion_r3672124464
##########
regression-test/suites/variant_p0/variant_compute_v2.groovy:
##########
@@ -18,8 +18,56 @@
suite("variant_compute_v2", "p0,nonConcurrent") {
sql "SET enable_nereids_planner = true"
sql "SET enable_fallback_to_original_planner = false"
+ def segmentScanTable = "variant_v2_segment_scan"
+ sql "DROP TABLE IF EXISTS ${segmentScanTable}"
+ sql """
+ CREATE TABLE ${segmentScanTable} (
+ id INT,
+ v VARIANT<PROPERTIES("variant_max_subcolumns_count" = "2")> NULL
+ )
+ DUPLICATE KEY(id)
+ DISTRIBUTED BY HASH(id) BUCKETS 1
+ PROPERTIES("replication_num" = "1")
+ """
+
+ // Storage writes remain on ColumnVariant. The same segment is scanned
into ColumnVariantV2
+ // after the session switch below.
+ sql "SET enable_variant_v2 = false"
Review Comment:
更新：新 head 已新增
`regression-test/suites/variant_p0/v2/insert_into_select.groovy`，在
`enable_variant_v2=true` 下覆盖了 Variant->String、String->Variant、Variant->Variant
的 `INSERT ... SELECT`。这已经补上行为级集成覆盖，因此这条按 current head 关闭；若后续希望更精确隔离
`createScanSlot`，再补 FE unit test 即可。
##########
be/src/core/column/variant_v2/column_variant_v2_typed_column.cpp:
##########
@@ -17,8 +17,38 @@
#include "core/column/variant_v2/column_variant_v2_typed_column.h"
+#include <cstring>
+
+#include "common/consts.h"
+
namespace doris {
+size_t variant_decimal256_to_chars(const Decimal256& value, uint8_t scale,
char* dst) {
Review Comment:
去掉这个代码decimal 256先不支持
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
