eldenmoon commented on code in PR #66204:
URL: https://github.com/apache/doris/pull/66204#discussion_r3672178728


##########
be/src/storage/segment/variant/binary_column_extract_iterator.h:
##########
@@ -208,8 +208,15 @@ class BinaryColumnExtractIterator : public 
BaseBinaryColumnProcessor {
             const size_t lower = 
ColumnVariant::find_path_lower_bound_in_sparse_data(
                     requested, *paths, previous_end, end);
             if (lower < end && paths->get_data_at(lower) == requested) {
-                cells.push_back(values->get_data_at(lower));
-                missing.push_back(0);
+                const StringRef cell = values->get_data_at(lower);
+                // Legacy sparse/doc storage writes a one-byte NONE cell as 
the placeholder for a

Review Comment:
   这里不用刻意区分SQL null和Variant null



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to