eldenmoon commented on code in PR #66204:
URL: https://github.com/apache/doris/pull/66204#discussion_r3672323417
##########
be/src/core/wide_integer_to_string.cpp:
##########
@@ -22,12 +22,38 @@
#include <fmt/format.h>
+#include <algorithm>
#include <string>
#include "core/wide_integer.h"
namespace wide {
+char* to_chars(const Int256& n, char* dst) {
+ if (Int256::_impl::operator_eq(n, 0U)) {
Review Comment:
删除这个文件的修改
##########
be/src/core/wide_integer_to_string.h:
##########
@@ -35,6 +35,10 @@ using UInt256 = wide::integer<256, unsigned>;
namespace wide {
+// Writes the base-10 representation to caller-owned storage and returns one
past the last byte.
Review Comment:
删除这个文件的修改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]