github-actions[bot] commented on code in PR #66221: URL: https://github.com/apache/doris/pull/66221#discussion_r3673622421
########## thirdparty/vars.sh: ########## @@ -261,12 +261,10 @@ GRPC_SOURCE=grpc-1.54.3 GRPC_MD5SUM="af00a2edeae0f02bb25917cc3473b7de" # arrow -# Arrow 19.0.1 will MacOS compile error and decimal type error when convert to Parquet. -# https://github.com/apache/doris/pull/51217 -ARROW_DOWNLOAD="https://github.com/apache/arrow/archive/refs/tags/apache-arrow-17.0.0.tar.gz"; -ARROW_NAME="apache-arrow-17.0.0.tar.gz" -ARROW_SOURCE="arrow-apache-arrow-17.0.0" -ARROW_MD5SUM="ba18bf83e2164abd34b9ac4cb164f0f0" +ARROW_DOWNLOAD="https://github.com/apache/arrow/archive/refs/tags/apache-arrow-24.0.0.tar.gz"; Review Comment: [P1] Raise the supported CMake floor before selecting Arrow 24 Arrow 24's `cpp/CMakeLists.txt` now requires CMake 3.25, but both macOS third-party workflows explicitly install 3.22.1 (and the gcc10 compilation image pins the same version). The current macOS and macOS-arm64 jobs both fail at this configure step with `CMake 3.25 or higher is required`; `CMAKE_POLICY_VERSION_MINIMUM` cannot override `cmake_minimum_required`. Please update every supported Arrow build path to provide CMake >=3.25 and regenerate the matching prebuilt archives before adopting this version, otherwise the standard macOS/toolchain builds remain unusable. ########## thirdparty/download-thirdparty.sh: ########## @@ -733,11 +733,11 @@ fi if [[ " ${TP_ARCHIVES[*]} " =~ " PAIMON_CPP " ]]; then cd "${TP_SOURCE_DIR}/${PAIMON_CPP_SOURCE}" if [[ ! -f "${PATCHED_MARK}" ]]; then - if patch -p1 -N --batch --dry-run <"${TP_PATCH_DIR}/paimon-cpp-buildutils-static-deps.patch" >/dev/null 2>&1; then - patch -p1 -N --batch <"${TP_PATCH_DIR}/paimon-cpp-buildutils-static-deps.patch" - else - echo "Skip paimon-cpp patch: already applied or not applicable for current source" - fi + for patch_file in \ + "${TP_PATCH_DIR}/paimon-cpp-buildutils-static-deps.patch" \ + "${TP_PATCH_DIR}/paimon-cpp-arrow-24-compatibility.patch"; do Review Comment: [P1] Invalidate the old Paimon patch marker `PAIMON_CPP_SOURCE` is unchanged, so an incremental tree already patched on the base commit still has `patched_mark`. This guard then skips this whole new loop, including `paimon-cpp-arrow-24-compatibility.patch`, leaving the removed three-argument `unique_ptr` out-parameter `GetRecordBatchReader` calls and bare `RETURN_NOT_OK` uses in place when building against Arrow 24. Please invalidate/re-extract the source when the patch set changes (for example with a patch-set-specific marker or a bumped source identity), so the documented rerunnable download flow cannot silently retain incompatible sources. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
