github-actions[bot] commented on code in PR #66221:
URL: https://github.com/apache/doris/pull/66221#discussion_r3679736129
##########
.github/workflows/be-ut-mac.yml:
##########
@@ -101,6 +109,17 @@ jobs:
-o doris-thirdparty-prebuilt-darwin-arm64.tar.xz
fi
tar -xvf doris-thirdparty-prebuilt-darwin-arm64.tar.xz
+
+ # A thirdparty upgrade can make the shared prebuilt archive stale.
+ # Rebuild the changed Arrow/Paimon stack before compiling BE so this
+ # job validates the versions selected by the PR.
+ if [[ "${{ steps.filter.outputs.thirdparty_changes }}" == "true" ]];
then
+ curl -L
https://github.com/apache/doris-thirdparty/releases/download/automation/doris-thirdparty-source.tgz
\
+ -o doris-thirdparty-source.tgz
+ tar -zxvf doris-thirdparty-source.tgz
+ export MACOSX_DEPLOYMENT_TARGET=12.0
+ ./build-thirdparty.sh -j "$(nproc)" arrow paimon_cpp
Review Comment:
[P1] Fetch xsimd 14 before this targeted Arrow build
Passing only `arrow paimon_cpp` restricts `download-thirdparty.sh` to those
two archives, but Arrow is configured with `xsimd_SOURCE=BUNDLED` and a local
`${TP_SOURCE_DIR}/14.0.0.tar.gz` URL. The shared source bundle does not contain
that newly selected archive, so the live macOS job fails in `xsimd_ep` with
`File not found: .../thirdparty/src/14.0.0.tar.gz` before Arrow is compiled.
Please download Arrow's complete source-only dependency closure (at least
xsimd) before this targeted build, or provide a source bundle guaranteed to
match the checked-out `vars.sh`.
##########
.github/workflows/be-ut-mac.yml:
##########
@@ -101,6 +109,17 @@ jobs:
-o doris-thirdparty-prebuilt-darwin-arm64.tar.xz
fi
tar -xvf doris-thirdparty-prebuilt-darwin-arm64.tar.xz
+
+ # A thirdparty upgrade can make the shared prebuilt archive stale.
+ # Rebuild the changed Arrow/Paimon stack before compiling BE so this
+ # job validates the versions selected by the PR.
+ if [[ "${{ steps.filter.outputs.thirdparty_changes }}" == "true" ]];
then
Review Comment:
[P2] Align this broad trigger with the dependency set actually rebuilt
`thirdparty_changes` matches every file under `thirdparty/**`, but this
branch always rebuilds only Arrow and Paimon. For example, a protobuf version
or patch change triggers this BE job while both Arrow and BE still consume
protobuf from the shared prebuilt, so a green result would not validate the
PR-selected dependency as the new comments imply. Please either narrow the
filter to the Arrow/Paimon inputs this step covers or derive and rebuild the
changed dependency set (including the required transitive closure).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
