hulincup opened a new pull request, #66332: URL: https://github.com/apache/doris/pull/66332
## Motivation PR #63744 removed the `auto_broadcast_join_threshold` session variable from `SessionVariable.java` (along with other deprecated/unused FE/BE configs and stale session variables). Per Doris's removed-variable contract (documented in `test_removed_session_variables.groovy`), `SET` / `SET_VAR` on a removed variable name **silently no-ops** for BE-then-FE rolling-upgrade backward compatibility — it does not throw, and it does not configure anything. Five regression-test suites still reference `auto_broadcast_join_threshold=-1` inside `/*+SET_VAR(...)*/` query hints, intending to disable auto-broadcast-join for those queries. Those hint entries are now silent no-ops: the tests believe they are configuring broadcast behavior, but the entry does nothing. ## Change Remove the stale `auto_broadcast_join_threshold=-1` entries from the `SET_VAR` hints in the five affected suites. In **every** occurrence it is paired with `broadcast_row_count_limit=0`, which is still a valid session variable and — at `0` (no rows may broadcast) — already disables broadcast join. So removing the stale entry is behavior-preserving; `broadcast_row_count_limit=0` continues to do the actual broadcast disabling. The other variables in the hints (`disable_join_reorder`, `disable_colocate_plan`, `ignore_storage_data_distribution`, `parallel_pipeline_task_num`) are all confirmed still present in `SessionVariable.java` and are left untouched. ## Files - `regression-test/suites/nereids_p0/local_shuffle/test_local_shuffle_global_hash_require.groovy` (4) - `regression-test/suites/nereids_p0/local_shuffle/test_local_shuffle_rqg_bugs.groovy` (4) - `regression-test/suites/nereids_p0/local_shuffle/test_local_shuffle_fe_be_consistency.groovy` (5) - `regression-test/suites/nereids_p0/local_shuffle/test_local_shuffle_bucket_upgrade.groovy` (1) - `regression-test/suites/query_p0/join/test_multilevel_join_agg_local_shuffle.groovy` (23) ## Verification - Confirmed `auto_broadcast_join_threshold` is absent from `SessionVariable.java` on master (removed by #63744). - Confirmed `broadcast_row_count_limit` and the other hint vars are still present in `SessionVariable.java`. - `grep auto_broadcast_join_threshold` across the five files returns zero hits after the change. - No structural Groovy changes — only removal of a `key=value,` token from comma-separated lists inside SQL hint string literals. ## Test plan - [ ] CI regression suites (`nereids_p0/local_shuffle/*`, `query_p0/join/test_multilevel_join_agg_local_shuffle`) pass unchanged — the removed hint entry was already a no-op, so test results are identical. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
