hulincup commented on PR #66332: URL: https://github.com/apache/doris/pull/66332#issuecomment-5141614501
Thanks for the checklist. Describing this PR per the points: **1. Problem fixed & how** PR #63744 removed the `auto_broadcast_join_threshold` session variable from `SessionVariable.java`. Per Doris's removed-variable contract (`regression-test/suites/query_p0/set/test_removed_session_variables.groovy`), `SET` / `SET_VAR` on a removed variable name silently no-ops for BE→FE rolling-upgrade compatibility — it neither throws nor configures anything. Five regression-test suites still carried `auto_broadcast_join_threshold=-1` inside `/*+SET_VAR(...)*/` query hints, intending to disable auto-broadcast-join, but those entries were silent no-ops. Removed the stale entries. **2. Behavior modified (previous vs. now, impact)** - *Previous:* the `auto_broadcast_join_threshold=-1` hint entry did nothing (already a no-op since #63744); `broadcast_row_count_limit=0` (still a valid var, set in every occurrence) was what actually disabled broadcast join. - *Now:* the dead `auto_broadcast_join_threshold=-1` entry is removed; `broadcast_row_count_limit=0` is preserved, so broadcast join is still disabled exactly as before. - *Impact:* behavior-preserving. The removed entry had no effect at runtime; the tests' actual broadcast-disabling comes from `broadcast_row_count_limit=0`, which is unchanged. No query plan changes. **3. Features added** — N/A. **4. Code refactored** — N/A. Only regression-test `.groovy` suites; no production FE/BE code touched. **5. Functions optimized** — N/A. The other variables in the hints (`disable_join_reorder`, `disable_colocate_plan`, `ignore_storage_data_distribution`, `parallel_pipeline_task_num`) are confirmed still present in `SessionVariable.java` and were left untouched. CI verification: `grep auto_broadcast_join_threshold` across the five files returns zero hits after the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
