github-actions[bot] commented on code in PR #66349:
URL: https://github.com/apache/doris/pull/66349#discussion_r3695278189
##########
.github/workflows/code-review-runner.yml:
##########
@@ -946,27 +949,61 @@ jobs:
OSS_ENDPOINT: oss-cn-hongkong.aliyuncs.com
OSS_CODEX_SESSION_PREFIX: oss://doris-community-ci/session
- - name: Sync Codex auth back to OSS
- if: ${{ always() }}
- continue-on-error: true
+ - name: Sync refreshed Codex auth back to OSS
+ if: ${{ always() && steps.auth.outcome == 'success' }}
timeout-minutes: 5
run: |
- if [ -z "$CODEX_AUTH_OSS_OBJECT" ]; then
- echo "No selected Codex auth object found; skipping OSS auth sync."
- exit 0
- fi
-
- if [ ! -s "$CODEX_HOME/auth.json" ]; then
- echo "No Codex auth file found; skipping OSS auth sync."
- exit 0
- fi
+ retry_oss_copy() {
+ local source="$1"
+ local destination="$2"
+ local description="$3"
+ for attempt in 1 2 3; do
Review Comment:
[P2] Bound the actual OSS retry policy
The workflow pins `ossutil` 1.7.19, whose `cp --help` defaults to 10
internal retries, a 120-second connect timeout, and a 1,200-second read
timeout. Each pass through this new loop can therefore retry many times or
outlive the entire five-minute step; a stalled first invocation is killed
before attempts 2/3 and the terminal `::error::`, while fast retryable failures
can produce roughly 30 client-level retries instead of the advertised three.
The mocked outer-loop retry cases do not exercise this nested policy. Please
use one bounded retry layer, or pass explicit native retry/connect/read
timeouts that leave room for all intended outer attempts and final diagnostics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
