github-actions[bot] commented on code in PR #66349:
URL: https://github.com/apache/doris/pull/66349#discussion_r3698192839
##########
.github/workflows/code-review-runner.yml:
##########
@@ -946,27 +949,61 @@ jobs:
OSS_ENDPOINT: oss-cn-hongkong.aliyuncs.com
OSS_CODEX_SESSION_PREFIX: oss://doris-community-ci/session
- - name: Sync Codex auth back to OSS
- if: ${{ always() }}
- continue-on-error: true
+ - name: Sync refreshed Codex auth back to OSS
+ if: ${{ always() && steps.auth.outcome == 'success' }}
timeout-minutes: 5
run: |
- if [ -z "$CODEX_AUTH_OSS_OBJECT" ]; then
- echo "No selected Codex auth object found; skipping OSS auth sync."
- exit 0
- fi
-
- if [ ! -s "$CODEX_HOME/auth.json" ]; then
- echo "No Codex auth file found; skipping OSS auth sync."
- exit 0
- fi
+ retry_oss_copy() {
+ local source="$1"
+ local destination="$2"
+ local description="$3"
+ for attempt in 1 2 3; do
Review Comment:
One timeout-budget follow-up remains in this existing thread. In pinned
ossutil v1.7.19, a non-recursive download is not a single retried request:
downloadSingleFile first runs the independently retried ossGetObjectStatRetry
HEAD, then the independently retried ossDownloadFileRetry GET; the later upload
has its own independently retried PUT. With three attempts, 10-second
connection and 30-second read limits, and the native sleeps, the foreground
envelope can be about 122 + 126 + 126 = 374 seconds, exceeding this step's
300-second limit. GitHub can therefore kill the step during PUT before all
intended attempts or the final ::error::. Please bound the whole HEAD + GET +
PUT sequence, or adjust the per-phase limits and step budget so the advertised
policy and terminal diagnostic fit. Sources:
https://github.com/aliyun/ossutil/blob/v1.7.19/lib/cp.go#L2498-L2504,
https://github.com/aliyun/ossutil/blob/v1.7.19/lib/cp.go#L2535-L2538,
https://github.com/aliyun/ossutil/blob/v1.7.19/lib/c
ommand.go#L658-L675,
https://github.com/aliyun/ossutil/blob/v1.7.19/lib/cp.go#L2219-L2246, and
https://github.com/aliyun/ossutil/blob/v1.7.19/lib/cp.go#L2606-L2633.
##########
.github/workflows/code-review-runner.yml:
##########
@@ -946,27 +949,46 @@ jobs:
OSS_ENDPOINT: oss-cn-hongkong.aliyuncs.com
OSS_CODEX_SESSION_PREFIX: oss://doris-community-ci/session
- - name: Sync Codex auth back to OSS
- if: ${{ always() }}
- continue-on-error: true
+ - name: Sync refreshed Codex auth back to OSS
+ if: ${{ always() && steps.auth.outcome == 'success' }}
timeout-minutes: 5
run: |
- if [ -z "$CODEX_AUTH_OSS_OBJECT" ]; then
- echo "No selected Codex auth object found; skipping OSS auth sync."
+ jq -e '
Review Comment:
[P2] Report invalid refreshed auth before failing
This predicate exits 1 without printing anything when Codex leaves
syntactically valid JSON but changes the auth mode or leaves either required
token empty. Since this sync is now fatal, the Actions log then contains only
the generic process exit; neither OSS diagnostic below runs, and the ephemeral
credential file cannot be inspected afterward. Please wrap this validation in
an explicit conditional and emit a credential-safe error identifying invalid
refreshed auth before exiting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
