Gabriel39 commented on code in PR #66247:
URL: https://github.com/apache/doris/pull/66247#discussion_r3698597115
##########
fe/fe-core/src/main/java/org/apache/doris/connector/ConnectorPluginManager.java:
##########
@@ -433,6 +458,19 @@ public void validateProperties(String catalogType,
Map<String, String> propertie
}
}
+ /** Validates an ALTER candidate through the matching provider without
mutating catalog state. */
+ public void validatePropertiesForUpdate(String catalogType,
+ Map<String, String> currentProperties, Map<String, String>
updatedProperties) {
+ for (ConnectorProvider provider : providers) {
+ Map<String, String> matchProperties = currentProperties == null
+ ? Collections.emptyMap() : currentProperties;
+ if (provider.supports(catalogType, matchProperties)) {
+ provider.validatePropertiesForUpdate(currentProperties,
updatedProperties);
Review Comment:
Fixed. Provider selection and update validation now run with the provider
defining classloader pinned as TCCL and restore the FE caller loader in
finally. A real directory-plugin regression resolves a plugin-local helper and
verifies restoration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
