yiguolei commented on code in PR #66328:
URL: https://github.com/apache/doris/pull/66328#discussion_r3701509794
##########
be/src/exec/spill/spill_file_manager.cpp:
##########
@@ -37,6 +37,40 @@
namespace doris {
+namespace {
+
+Status delete_empty_directory_tree(const std::string& dir) {
+ const auto& fs = io::global_local_filesystem();
+ auto status = fs->delete_empty_directory(dir);
+ if (status.ok() || !status.is<ErrorCode::DIRECTORY_NOT_EMPTY>()) {
Review Comment:
这个为什么要判断，是否是empty？？
比如我们一个spill 在异常路径上，throw exception 啥的，当我们走到析构query context的时候，此时怎么保证dir
是empty的？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
