github-actions[bot] commented on code in PR #66328:
URL: https://github.com/apache/doris/pull/66328#discussion_r3702145349
##########
be/test/vec/spill/spill_file_test.cpp:
##########
@@ -889,6 +915,77 @@ TEST_F(SpillFileTest, GCCleansUpFiles) {
ASSERT_FALSE(exists);
}
+TEST_F(SpillFileTest, QueryContextCleansUpEmptySpillDirectory) {
Review Comment:
[P2] Cover cleanup across multiple spill roots
This fixture installs only one `SpillDataDir`, so every added test would
still pass if `QueryContext` retained only one touched root or stopped cleanup
after the first root failed. Production creates one store per configured spill
path and selects a root independently for each new spill file, so a
long-running query can populate multiple roots. Please add a deterministic
two-root test that touches both roots and proves teardown removes both; ideally
inject one deletion failure and verify cleanup still reaches the other root.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
