github-actions[bot] commented on code in PR #66349:
URL: https://github.com/apache/doris/pull/66349#discussion_r3704049346
##########
.github/workflows/code-review-runner.yml:
##########
@@ -946,27 +949,61 @@ jobs:
OSS_ENDPOINT: oss-cn-hongkong.aliyuncs.com
OSS_CODEX_SESSION_PREFIX: oss://doris-community-ci/session
- - name: Sync Codex auth back to OSS
- if: ${{ always() }}
- continue-on-error: true
+ - name: Sync refreshed Codex auth back to OSS
+ if: ${{ always() && steps.auth.outcome == 'success' }}
timeout-minutes: 5
run: |
- if [ -z "$CODEX_AUTH_OSS_OBJECT" ]; then
- echo "No selected Codex auth object found; skipping OSS auth sync."
- exit 0
- fi
-
- if [ ! -s "$CODEX_HOME/auth.json" ]; then
- echo "No Codex auth file found; skipping OSS auth sync."
- exit 0
- fi
+ retry_oss_copy() {
+ local source="$1"
+ local destination="$2"
+ local description="$3"
+ for attempt in 1 2 3; do
Review Comment:
[P2] One timeout-budget follow-up remains because the 374-second envelope
still assumes each native attempt is capped at connect plus read. Pinned
`ossutil` 1.7.19 passes `--read-timeout=30` to aliyun-oss-go-sdk v3.0.2
`oss.Timeout`; that transport resets the 30-second read/write deadline on every
`Read`/`Write`, and `GetObjectToFile` streams the response with `io.Copy`. A
slow-progressing response can therefore keep a single GET alive beyond the
eight-minute step even though no individual I/O is idle for 30 seconds, so
GitHub can kill the finalizer before all intended attempts or the explicit
`::error::`. Please add a hard wall-clock bound to each transfer/attempt,
budget the retry layer and final diagnostic inside the step, and cover a
slow-progress case in the mock. Sources: [ossutil option
mapping](https://github.com/aliyun/ossutil/blob/v1.7.19/lib/command.go#L443-L459),
[SDK timeout
setup](https://github.com/aliyun/aliyun-oss-go-sdk/blob/v3.0.2/oss/client.go#L2709-L2726),
[pe
r-I/O deadline
reset](https://github.com/aliyun/aliyun-oss-go-sdk/blob/v3.0.2/oss/conn.go#L810-L837),
and [streamed file
download](https://github.com/aliyun/aliyun-oss-go-sdk/blob/v3.0.2/oss/bucket.go#L145-L170).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
