HappenLee commented on code in PR #66553:
URL: https://github.com/apache/doris/pull/66553#discussion_r3735112343
##########
be/src/storage/segment/row_binlog_segment_writer.cpp:
##########
@@ -453,6 +467,12 @@ bool RowBinlogSourceDataWriter::is_normal_column(uint32_t
source_cid) const {
_normal_column_ids.end();
}
+bool RowBinlogSourceDataWriter::is_after_column(uint32_t source_cid) const {
Review Comment:
这个名字感觉不是很正确，before也得加nullable，你这也能判断出来before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
