luwei16 commented on code in PR #66553:
URL: https://github.com/apache/doris/pull/66553#discussion_r3736892214
##########
be/src/storage/segment/row_binlog_segment_writer.cpp:
##########
@@ -453,6 +467,12 @@ bool RowBinlogSourceDataWriter::is_normal_column(uint32_t
source_cid) const {
_normal_column_ids.end();
}
+bool RowBinlogSourceDataWriter::is_after_column(uint32_t source_cid) const {
Review Comment:
确实，这个名字不太准确。这里拿到的是源表列，它本身没有 AFTER 或 BEFORE 的区别，所以我把判断改成
`is_row_binlog_value_column`，nullable 包装也改成
`make_nullable_row_binlog_value_column`。
`prepare_by_source_block()` 这条路径里，源表普通 value 列接下来用于写 AFTER，所以局部变量叫
`source_column_for_after`。BEFORE 不走这里，而是在 `_fill_before_columns()`
中从历史行单独构造，那里已经处理好了 nullable。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
