linrrzqqq commented on code in PR #66050:
URL: https://github.com/apache/doris/pull/66050#discussion_r3809590844
##########
be/src/exprs/function/function_regexp.cpp:
##########
Review Comment:
> For the newly supported `idx = 0`, this drops valid zero-length matches
before the selected group is appended, and `while (pos < size)` also skips a
terminal match. For example, `regexp_extract_all('b', 'a*', 0)` returns `[]`
here, while Spark's matcher yields ["", ""] (offsets 0 and 1); empty
input/pattern should similarly yield one empty match. Please emit the selected
group for successful empty matches and advance safely while allowing one
terminal-position search.
fix this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
