ccl125 commented on code in PR #66050:
URL: https://github.com/apache/doris/pull/66050#discussion_r3809852455
##########
be/src/exprs/function/function_regexp.cpp:
##########
Review Comment:
Fixed in 1bcc272 — explicit group-index calls now follow Spark exactly:
zero-width matches are emitted ('b','a*',0 -> ['',''] and '' -> ['']), one
terminal-position search is allowed, and advancement is UTF-8-safe (whole
characters, no continuation-byte splits). The legacy two-argument form keeps
the old skip behavior, covered by a dedicated case. New unit cases added for
all three examples.
##########
be/src/exprs/function/function_regexp.cpp:
##########
Review Comment:
Also fixed in 1bcc272 — input null maps are now merged before validation, so
`(NULL,'(a)',99), ('hitdecisiondlist','(i)(.*?)(e)',3)` yields NULL for the
first row and ['e'] for the second instead of aborting on the garbage index. A
dedicated two-row nullable-block test covers it. The UTF-8-unsafe advance in
the boost path is fixed the same way (whole-character steps via
get_utf8_byte_length).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
