gavinchou commented on code in PR #66598:
URL: https://github.com/apache/doris/pull/66598#discussion_r3818516969
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -3938,12 +4010,36 @@ void _write_delete_bitmap_kvs(MetaServiceCode& code,
std::string& msg, std::stri
}
// remove first
if (request->lock_id() == COMPACTION_WITHOUT_LOCK_DELETE_BITMAP_LOCK_ID) {
- auto& start_key = key;
- std::string end_key {start_key};
- encode_int64(INT64_MAX, &end_key);
- txn->remove(start_key, end_key);
- LOG(INFO) << "xxx remove delete_bitmap_key=" << hex(start_key) << "
tablet_id=" << tablet_id
- << " lock_id=" << request->lock_id() << " initiator=" <<
request->initiator();
+ bool point_delete = false;
+ bool delete_bitmap_exists = false;
+ std::optional<size_t> max_blob_sequence;
+ if (!check_delete_bitmap_point_delete(code, msg, txn, key, val,
request, point_delete,
+ delete_bitmap_exists,
max_blob_sequence)) {
+ return;
+ }
+ if (point_delete) {
+ if (delete_bitmap_exists) {
+ if (max_blob_sequence.has_value()) {
+ for (size_t sequence = 0; sequence <= *max_blob_sequence;
++sequence) {
+ txn->remove(blob_key(key, sequence));
+ }
+ } else {
+ txn->remove(key);
Review Comment:
comment for older version<> compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
