gavinchou commented on code in PR #66598:
URL: https://github.com/apache/doris/pull/66598#discussion_r3818530071


##########
cloud/src/meta-store/blob_message.cpp:
##########
@@ -40,6 +40,35 @@ static std::vector<std::string_view> split_string(const 
std::string_view& str, i
     return substrings;
 }
 
+std::string blob_key(std::string_view key, size_t sequence, uint8_t ver) {
+    std::string split_key(key);
+    int64_t suffix = ver;
+    suffix <<= 56;
+    suffix += static_cast<int64_t>(sequence);
+    encode_int64(suffix, &split_key);
+    return split_key;
+}
+
+bool decode_blob_key(std::string_view raw_key, std::string* output, uint8_t* 
version,

Review Comment:
   `output` should be a `string_view*`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to