924060929 commented on code in PR #66913:
URL: https://github.com/apache/doris/pull/66913#discussion_r3838732878
##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectProcessor.java:
##########
@@ -773,8 +777,17 @@ public TMasterOpResult proxyExecute(TMasterOpRequest
request) throws TException
LOG.warn("Process one query failed because unknown reason: ", e);
ctx.getState().setError(ErrorCode.ERR_UNKNOWN_ERROR, "Unexpected
exception: " + e.getMessage());
}
- // no matter the master execute success or fail, the master must
transfer the result to follower
- // and tell the follower the current journalID.
+ try {
+ return buildProxyResult(request, executor);
+ } finally {
+ if (ctx.getStatementContext() != null) {
+ ctx.getStatementContext().close();
Review Comment:
这条评论涉及通用查询、任务、Streaming、Flight、Hive 或其他非本 PR 生命周期问题，不属于本 PR 仅处理 Hudi/Iceberg
资源关闭与泄露的范围。当前 head 已撤回对应旁支改动，本 PR 忽略该问题。
##########
fe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java:
##########
@@ -784,6 +785,9 @@ private boolean shouldQueue() {
// A call to Exec() must precede all other member function calls.
@Override
public void exec() throws Exception {
+ if (isQueryCancelled()) {
Review Comment:
这条评论涉及通用查询、任务、Streaming、Flight、Hive 或其他非本 PR 生命周期问题，不属于本 PR 仅处理 Hudi/Iceberg
资源关闭与泄露的范围。当前 head 已撤回对应旁支改动，本 PR 忽略该问题。
##########
fe/fe-core/src/main/java/org/apache/doris/qe/StmtExecutor.java:
##########
@@ -502,6 +506,12 @@ public boolean isCached() {
// query with a random sql
public void execute() throws Exception {
+ synchronized (executionAdmissionLock) {
+ if (pendingCancelReason != null) {
Review Comment:
这条评论涉及通用查询、任务、Streaming、Flight、Hive 或其他非本 PR 生命周期问题，不属于本 PR 仅处理 Hudi/Iceberg
资源关闭与泄露的范围。当前 head 已撤回对应旁支改动，本 PR 忽略该问题。
##########
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java:
##########
@@ -1214,6 +1227,10 @@ public TMasterOpResult forward(TMasterOpRequest params)
throws TException {
Runnable clearCallback = () -> {};
if (params.isSetQueryId()) {
proxyQueryIdToConnCtx.put(params.getQueryId(), context);
+ if (pendingProxyQueryCancels.remove(params.getQueryId()) != null) {
Review Comment:
这条评论涉及通用查询、任务、Streaming、Flight、Hive 或其他非本 PR 生命周期问题，不属于本 PR 仅处理 Hudi/Iceberg
资源关闭与泄露的范围。当前 head 已撤回对应旁支改动，本 PR 忽略该问题。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
