924060929 commented on code in PR #66913:
URL: https://github.com/apache/doris/pull/66913#discussion_r3838733357


##########
fe/fe-core/src/main/java/org/apache/doris/service/arrowflight/sessions/FlightSqlConnectPoolMgr.java:
##########
@@ -56,6 +58,12 @@ public int registerConnection(ConnectContext ctx) {
 
     @Override
     public void unregisterConnection(ConnectContext ctx) {
+        // Reject new publications first, then signal the active query before 
waiting for an admitted
+        // GetFlightInfo publisher. Waiting before cancellation can deadlock 
KILL CONNECTION behind the
+        // publisher whose query must be canceled in order to leave 
publication.
+        ctx.sealFlightSqlDeferredExecutors();
+        ctx.cancelQuery(new Status(TStatusCode.CANCELLED, "arrow flight 
connection closed"));

Review Comment:
   这条评论涉及通用查询、任务、Streaming、Flight、Hive 或其他非本 PR 生命周期问题,不属于本 PR 仅处理 Hudi/Iceberg 
资源关闭与泄露的范围。当前 head 已撤回对应旁支改动,本 PR 忽略该问题。



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to